-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add styling for output layer of main plugin #188
Conversation
@merydian What about taking the colour we also use in our maps client? |
Should we add the start and endpoint markers as well? |
Could you add a screenshot with start- and endpoint-markers, and the current style? That would make it easier to reason about :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise, this looks good.
Changelog entry is missing.
Could this be added to the routes from the processing algorithms as well? There, we should however switch to random colors, as it currently happens - otherwise routes won't be very discernable…
We should check the behaviour with default styles as well. (The default styles set by user). |
Basic blue line from QGis default styles.
Namely #C62828 7px and #fff 11px.
c50e8be
to
a293b29
Compare
We discussed this and settled on overwriting any default style for the "frontend" - people setting a default style know enough to apply their changes after the fact, and processing algorithm behaviour won't be changed. |
Basic blue line from QGis default styles.