Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add styling for output layer of main plugin #188

Merged
merged 6 commits into from
Dec 21, 2023

Conversation

merydian
Copy link
Collaborator

@merydian merydian commented Nov 1, 2023

Basic blue line from QGis default styles.

image

@merydian merydian linked an issue Nov 1, 2023 that may be closed by this pull request
@MichaelsJP
Copy link
Member

@merydian What about taking the colour we also use in our maps client?
Seems a bit more aligned.

image

@merydian merydian marked this pull request as draft November 3, 2023 16:25
@merydian
Copy link
Collaborator Author

merydian commented Nov 6, 2023

Should we add the start and endpoint markers as well?

@koebi koebi self-requested a review November 6, 2023 17:00
@koebi
Copy link
Collaborator

koebi commented Nov 17, 2023

Could you add a screenshot with start- and endpoint-markers, and the current style? That would make it easier to reason about :)
Tagging @TheGreatRefrigerator here for more input/ideas.

Copy link
Collaborator

@koebi koebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise, this looks good.
Changelog entry is missing.

Could this be added to the routes from the processing algorithms as well? There, we should however switch to random colors, as it currently happens - otherwise routes won't be very discernable…

@TheGreatRefrigerator
Copy link
Collaborator

We should check the behaviour with default styles as well. (The default styles set by user).
Not sure if we want to override explicit settings a user made. Or give an additional option to not style the output?

@koebi koebi force-pushed the 149-add-styling-from-qml-file branch from c50e8be to a293b29 Compare December 8, 2023 14:19
@koebi koebi added this to the Version 1.7 milestone Dec 15, 2023
@koebi
Copy link
Collaborator

koebi commented Dec 21, 2023

We should check the behaviour with default styles as well. (The default styles set by user). Not sure if we want to override explicit settings a user made. Or give an additional option to not style the output?

We discussed this and settled on overwriting any default style for the "frontend" - people setting a default style know enough to apply their changes after the fact, and processing algorithm behaviour won't be changed.

@koebi koebi marked this pull request as ready for review December 21, 2023 15:14
@koebi koebi merged commit 1d1e856 into main Dec 21, 2023
2 checks passed
@koebi koebi deleted the 149-add-styling-from-qml-file branch December 21, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add styling from .qml-file
4 participants