docs(topojson-export): add topojson response documentation #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chwiggy
force-pushed
the
feat/add-topojson-graph-export-rebase
branch
from
3acd60a to
5efeced
Compare
|
What about making the |
When requesting a topojson export, the accept-header must be set to 'json' not 'topojson' because topojson is not yet an official content type. Instead of just telling that topojson is invalid, the error message now hints to using json instead.
I tried to find a smaller selection where the difference is visible. While doing so I discovered a potential bug in the TopoJSON creation, will need to look a bit further tomorrow... |
koebi
requested changes
Dec 17, 2024
ors-api/src/main/java/org/heigit/ors/api/responses/export/json/JsonEdge.java
Outdated
Show resolved
Hide resolved
added 2 commits
December 18, 2024 10:21
The message now clarifies that the TopoJSON output format of the export endpoint requires, both, accept header and content type to be specified as application/json.
Moving more towards the principle "parse, don't validate" enables simplifying the conversion of the API-level request into a core-level request and prepares factoring out common behavior of multiple endpoints.
koebi
reviewed
Dec 18, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes # .
Information about the changes