Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Autocomplete experience orgs #12427

Merged
merged 10 commits into from
Jan 8, 2025
Merged

Conversation

vd1992
Copy link
Contributor

@vd1992 vd1992 commented Jan 7, 2025

🤖 Resolves #12323

👋 Introduction

Populate with suggestions, using <datalist />, orgs for all experiences except personal by pulling names from all experiences except personal.
There are two contexts for experiences, through timeline and within an application. A util function for reuse was added as well due to more than one context

🧪 Testing

  1. Login and have experiences
  2. Create/edit experiences and observe whether suggestions were populated for org name

📸 Screenshot

image

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems <datalist /> turns textboxes into comboboxes

🤷

Copy link
Member

@esizer esizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far, just two minor suggestions.

apps/web/src/utils/experienceUtils.tsx Outdated Show resolved Hide resolved
@vd1992 vd1992 requested a review from esizer January 8, 2025 20:24
Copy link
Member

@esizer esizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@vd1992 vd1992 added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit e41b622 Jan 8, 2025
15 checks passed
@vd1992 vd1992 deleted the 12323-autocomplete-experience-orgs branch January 8, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Autocomplete for experience orgs
2 participants