[Fix] Add token validation to didAuthError and allowable clock skew to willAuthError #12418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petertgiles
commented
Jan 3, 2025
| (e) => e.extensions?.category === "authentication", | ||
| (e) => | ||
| e.extensions?.category === "authentication" || | ||
| e.extensions?.reason === "token_validation", // the auth provider says the token is invalid - maybe just a refresh is needed |
There was a problem hiding this comment.
The cleaner solution might be to update our openID provider to return a 401. This would be a bigger change because a lot of tests watch for this reason code now.
brindasasi
reviewed
Jan 3, 2025
| tokenIsKnownToBeExpired = Date.now() > decoded.exp * 1000; // JWT expiry date in seconds, not milliseconds | ||
| const tokenExpiryDateSeconds = decoded.exp; | ||
| const safeTokenExpiryDateSeconds = | ||
| tokenExpiryDateSeconds - allowableClockSkewSeconds; // allow for the client's machine to be a bit off |
There was a problem hiding this comment.
yeah .. this is what I did as well .. but I didn't see the refresh happening earlier than 10 mins .. may be let's try yours
brindasasi
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Resolves #12369
👋 Introduction
We've been getting lots of reports of premature logouts with our app. Our best explanation is that the Surface tablets appear to have over 5 seconds of clock skew which means that the client is attempting to use an expired token. Also, URQL is not configured to recognize the token_validation error and so it does not attempt to refresh when it gets the error. This PR attempts to fix both problems.
🕵️ Details
🧪 Testing
DidAuthError
verifyJwtWithIntrospectionin api/app/Services/OpenIdBearerTokenService.php and to simulate an expired token.WillAuthError
📸 Screenshot