-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milstein function #615
base: develop
Are you sure you want to change the base?
Milstein function #615
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #615 +/- ##
===========================================
+ Coverage 86.65% 86.90% +0.24%
===========================================
Files 156 158 +2
Lines 13322 13568 +246
===========================================
+ Hits 11544 11791 +247
+ Misses 1778 1777 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried to do a quick review, so that you can incorporate the feedback before your presentation, but I did not review the math nor the code/tests correctness.
and Postintervention in Structural Equation Models. PhD thesis, USA, | ||
2020. AAI29605510 | ||
""" | ||
random_state = validate_random_state(random_state) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not have the bandwidth now to check for code correctness in depth. I will assume that Alberto has reviewed the code and tests with you thoroughly. If that is not true, please let me now to recheck it later before merging.
References to issues or other PRs
Describe the proposed changes
Added milstein function which computes the Milstein scheme for Stochastic Differential Equations (SDEs). Additionally, examples which show the functionality of the SDE solvers are added.
Additional information
Checklist before requesting a review