Freeplay results screen #4105
Open
Freeplay results screen #4105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: pending triage
Hundrec
added
size: medium
|
Please base this (and all other feature PRs) on the develop branch. |
|
@Hundrec How do I go about rebasing this branch off the development one? |
|
There should be an option at the top of the screen to change the base branch from main to develop! |
Lasercar
force-pushed
the
freeplay-results-screen
branch
from
83cc662 to
83b30b2
Compare
|
oh cool, that works. letme go do that for all my PRs. |
Hundrec
added
status: pending triage
|
Thanks for fixing things up Lasercar! |
|
No problem. Now you can checkout them without issue! |
…into freeplay-results-screen
No one will ever know it was me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
#2441
Briefly describe the issue(s) fixed.
Opens a results screen for the current song and difficulty when you press R (currently hardcoded) and it has a score.
I would have it open in a substate and then close it to return to the Freeplay menu so you don't have to reload the freeplay state but doing that seems to cause the freeplay state to become a weird pink screen?
Include any relevant screenshots or videos.
2025-02-05.20-23-23.mp4