Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Actually check if the Playable Character is unlocked #3748

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

AbnormalPoof
Copy link
Contributor

@AbnormalPoof AbnormalPoof commented Oct 21, 2024

Does this PR close any issues? If so, link them below.

Fixes #3747

Briefly describe the issue(s) fixed.

CharSelectSubState never actually checked to see if the playable character was unlocked before pushing them to nonLocks (to play the unlock animation). The only thing it did was check to see if the playable character ID was in Save.instance.charactersSeen, if it wasn't, it would be pushed to nonLocks and still play the unlock animation despite never actually unlocking them.

This, in turn, basically unlocked Pico right from the get-go if you entered the Character Select screen early, whether it be through a modded Playable Character, or the Debug Menu.

Include any relevant screenshots or videos.

screenshot-2024-10-21-10-26-47
Now, Pico remains locked (since WeekEnd 1 was never beaten), while Madoka (a modded playable character) is unlocked.

@github-actions github-actions bot added haxe Issue/PR modifies game code small A small pull request with 10 or fewer changes labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
haxe Issue/PR modifies game code small A small pull request with 10 or fewer changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant