[BUGFIX] Fix Audio/Visual Offset causing skips on song start #3732
+13
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting the song previously utilized combinedOffset to offset where in the song the instrumental starts in.
This is no longer the case, instead using instrumentalOffset for starting.
The Conductor and Countdown classes have been altered to reflect this behavior.
function startSong also no longer uses resyncVocals().
It was kind of pointless being there, and needing to play the instrumental before calling it makes the audio double up sometimes and it sounds awful
Does this PR close any issues? If so, link them below.
[TBA, but quick searches about offset don't show much]
Briefly describe the issue(s) fixed.
Audio used to skip forward when negative values of Audio/Visual Offset were present. This is now fixed, along with ugly audio doubling behavior on start.
Include any relevant screenshots or videos.
BEFORE:
2024-10-19.17-06-43.mp4
AFTER:
2024-10-19.17-04-39.mp4
(recorded on -210ms audio/visual offset. yes my headphones are that bad, yes they are bluetooth)