-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Prevent Stacked Notes #3574
base: develop
Are you sure you want to change the base?
[Enhancement] Prevent Stacked Notes #3574
Conversation
I'd personally just either have a check, which is done every time you paste, that removes all stacked notes, or if you want to a button that does it for you. |
I'd say giving the charter the freedom to create stacked notes is important. Having an adjustable threshold for what constitutes as "stacked" (0-100ms, for example) could go a long way to enable that freedom |
Unless you're like making a spam/joke chart, then yeah maybe? |
I thought stacked meant exactly 0ms, but i guess it is nice to have a threshold for more control |
I thought of having that customization feature because I've found that Funkin's chart editor would often place notes in an imprecise manner back in the legacy versions. |
This comment was marked as outdated.
This comment was marked as outdated.
24f1dd9
to
5834279
Compare
Finally, the messy commit history is no more. |
d2111cd
to
40f3373
Compare
ba9f177
to
2a91ff3
Compare
4b9b87a
to
b68f06d
Compare
i tested it out, and it is faster than the previous implementation
b68f06d
to
9cb171a
Compare
What is this?
Inspired by a comment by Hundrec and the many issues about notes stacked on top of each other, this PR intends to add a way to prevent these pesky notes.
Current visualization of stacked/overlapped notes is below
To Do
Suggestions are very welcome.