Fix the character select cursor lerp for lower framerates #3507
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe all instances of the deprecated coolLerp function in the game should just be replaced with smoothLerp? Or would that still cause a bunch of issues |
|
coolLerp interpolates in a different way than smoothLerp, smoothLerp interpolates in a given time, so for each instance you'd need to tweak some values to be able to match the lerp visually |
ninjamuffin99
force-pushed
the
develop
branch
2 times, most recently
from
e0b1b01 to
410cfe9
Compare
ninjamuffin99
force-pushed
the
ninjamuffin99/funk-1023
branch
from
1373f47 to
11d3420
Compare
Hundrec
added
type: minor bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3505
Updating the main cursor to use the
smoothLerp()instead ofcoolLerp()seems to fix it, as the rest of the squares lerp towards the main yellow cursor.I believe this bug is caused from the lerp overshooting and needing to recorrect itself using the old lerp method