Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIXES] Cool fixes to Character Select #3457

Merged

Conversation

gamerbross
Copy link
Contributor

Does this PR close any issues? If so, link them below.

Fixes #3365, Fixes #3220 (same issue)
Maybe #3381 (not sure, it's really hard to replicate, but i bet it got fixed)
Fixes #3302 (already got fixed internally?)
Fixes #3201
Fixes #3381

Briefly describe the issue(s) fixed.

  • Players and GFs were not changing properly when spamming while having a little lag
  • Showing BF's GF for some frames instead of the displayed character's GF (like Nene or whatever else)
  • Confirm and Deny cursors not updating (changing the character before the normal cursor has moved completely)
  • Fixes weird double BF after 1.5 seconds of entering
  • Character not changing for the first 1.5 seconds of entering
  • Spamming BF and locked character before pico gets unlocked, will show a bf behind pico (NOT SURE IF FIXED)

I think this menu got fixed a lot internally, but maybe not every of these

Include any relevant screenshots or videos.

All the videos are BEFORE the changes, to see after, it's better to try it yourself

Recording.2024-09-25.202848.-.Trim.mp4

shows most issues


image
moving from locked to pico


Recording.2024-09-25.203256.mp4

cursors not moving entirely


Recording.2024-09-25.203541.mp4

double bf and characters not changing

@ninjamuffin99
Copy link
Member

holup my bad gamerbros i fucked up da rebase bro...

@ninjamuffin99 ninjamuffin99 merged commit c5a76cf into FunkinCrew:develop Sep 30, 2024
@ninjamuffin99 ninjamuffin99 mentioned this pull request Sep 30, 2024
@EliteMasterEric EliteMasterEric added status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: needs revision Cannot be approved because it is awaiting some work by the contributor. labels Oct 1, 2024
@EliteMasterEric EliteMasterEric added this to the 0.5.2 milestone Oct 1, 2024
@gamerbross
Copy link
Contributor Author

what do i do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment