-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIXES] Cool fixes to Character Select #3457
Merged
ninjamuffin99
merged 226 commits into
FunkinCrew:develop
from
gamerbross:bugfix/character-selector-fixes
Sep 30, 2024
Merged
[BUGFIXES] Cool fixes to Character Select #3457
ninjamuffin99
merged 226 commits into
FunkinCrew:develop
from
gamerbross:bugfix/character-selector-fixes
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ween to classic should be fixed now?
…prop-flipx [PUBLIC PR] Add flipX and flipY parameters to Stage props
…into rewrite/master
… continuing in Freeplay.
…ith high offstes.
[PUBLIC PR] Two bug fixes
ninjamuffin99
force-pushed
the
bugfix/character-selector-fixes
branch
from
September 30, 2024 21:22
fff3d6b
to
c5a76cf
Compare
holup my bad gamerbros i fucked up da rebase bro... |
Closed
EliteMasterEric
added
status: accepted
Approved for contribution. If it's not already merged, it may be merged on a private branch.
and removed
status: needs revision
Cannot be approved because it is awaiting some work by the contributor.
labels
Oct 1, 2024
what do i do |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status: accepted
Approved for contribution. If it's not already merged, it may be merged on a private branch.
type: minor bug
Involves a minor bug or issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
Fixes #3365, Fixes #3220 (same issue)
Maybe #3381 (not sure, it's really hard to replicate, but i bet it got fixed)
Fixes #3302 (already got fixed internally?)
Fixes #3201
Fixes #3381
Briefly describe the issue(s) fixed.
I think this menu got fixed a lot internally, but maybe not every of these
Include any relevant screenshots or videos.
All the videos are BEFORE the changes, to see after, it's better to try it yourself
Recording.2024-09-25.202848.-.Trim.mp4
shows most issues
moving from locked to pico
Recording.2024-09-25.203256.mp4
cursors not moving entirely
Recording.2024-09-25.203541.mp4
double bf and characters not changing