Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Move the week directory to be loaded from PlayStatePlaylist to StageData, alongside some other changes to StageDataProp #3397

Closed

Conversation

JustKolosaki
Copy link
Contributor

Does this PR close any issues? If so, link them below.

N/A

Briefly describe the issue(s) fixed.

Adds a new field to StageData, "directory", which is read by LoadingState and sets the current level of Paths to the field's value and then loads it. The default value is "shared".

Alongside it, it adds three new fields to StageDataProp, "angle" (Float, default value 0.0), "blend" (String, default value "") and "color" (String, default value "#FFFFFF"), which are read in Stage and set to the corresponding StageProps.

Include any relevant screenshots or videos.

N/A

Note

If this gets accepted, stage files would need to be updated to at least contain the "directory" field.

@EliteMasterEric EliteMasterEric self-assigned this Sep 21, 2024
@EliteMasterEric EliteMasterEric added type: enhancement Provides an enhancement or new feature. mods Issue is related to the use of mods. status: reviewing internally This PR is under internal review and quality assurance testing labels Sep 21, 2024
@EliteMasterEric
Copy link
Member

These seem great! Will look into it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mods Issue is related to the use of mods. status: reviewing internally This PR is under internal review and quality assurance testing type: enhancement Provides an enhancement or new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants