[ENHANCEMENT] Move the week directory to be loaded from PlayStatePlaylist to StageData, alongside some other changes to StageDataProp #3397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stage files may or may not need to be updated
EliteMasterEric
added
type: enhancement
|
These seem great! Will look into it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
N/A
Briefly describe the issue(s) fixed.
Adds a new field to StageData, "directory", which is read by LoadingState and sets the current level of Paths to the field's value and then loads it. The default value is "shared".
Alongside it, it adds three new fields to StageDataProp, "angle" (Float, default value 0.0), "blend" (String, default value "") and "color" (String, default value "#FFFFFF"), which are read in Stage and set to the corresponding StageProps.
Include any relevant screenshots or videos.
N/A
Note
If this gets accepted, stage files would need to be updated to at least contain the "directory" field.