[BUGFIX] Make % Cleared not save to a lower amount when the song is completed with the same #3368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes the bug with the percent being overriden when the song has the same letter rank but lower percent (eg. E Rank with 99% being overriden by E Rank with 93%)
|
#3019 also tries to fix this bug. |
my bad, didnt notice,,,, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
2821 (theres probs more idk)
Briefly describe the issue(s) fixed.
Fixes the issue of the song % being overriden by a lower one when the song is completed with the same rank. It modifies the applySongRank function in Save to check for percentage differences (percentage formula copied from FreeplayState lol) instead of rank differences when saving the tallies.
Image shows previous %, video shows the latest % (in video form to show da code change !)
Include any relevant screenshots or videos.
2024-09-18.14-05-16.mp4