Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix bug where FPS counter was always displaying on startup even when disabled #3356

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

Lethrial
Copy link
Contributor

Does this PR close any issues? If so, link them below.

N/A

Briefly describe the issue(s) fixed.

Fixes a minor bug where the FPS counter object was added regardless of what the Debug Display option was set to.

Include any relevant screenshots or videos.

2024-09-18.00-34-24.mp4

@EliteMasterEric
Copy link
Member

EliteMasterEric commented Sep 18, 2024

If the debug display option is ON, does it correctly display on startup?

EDIT: Reviewed and it does.

approved

@EliteMasterEric EliteMasterEric added type: minor bug Involves a minor bug or issue. status: reviewing internally This PR is under internal review and quality assurance testing labels Sep 18, 2024
@EliteMasterEric EliteMasterEric changed the title [BUGFIX] FPS counter stays off on game launch if Debug Display is off [BUGFIX] Fix bug where FPS counter was always displaying even when disabled Sep 18, 2024
@EliteMasterEric EliteMasterEric changed the title [BUGFIX] Fix bug where FPS counter was always displaying even when disabled [BUGFIX] Fix bug where FPS counter was always displaying on startup even when disabled Sep 18, 2024
@EliteMasterEric EliteMasterEric added status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally This PR is under internal review and quality assurance testing labels Sep 18, 2024
@EliteMasterEric EliteMasterEric added this to the 0.5.1 milestone Sep 18, 2024
@EliteMasterEric EliteMasterEric self-assigned this Sep 19, 2024
@EliteMasterEric EliteMasterEric changed the base branch from main to develop September 25, 2024 12:56
@ninjamuffin99 ninjamuffin99 merged commit 4946e7f into FunkinCrew:develop Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants