-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for video cutscenes in polymod using hxvlc
.
#2639
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
goated.
if (vid.load(bytes)) | ||
vid.play(); | ||
|
||
onVideoStarted.dispatch(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, you just forgot to remove this line you copied from VideoCutscene
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, you just forgot to remove this line you copied from VideoCutscene
My bad
@NotHyper-474 your issue should be gone now as the paths are no longer striped. |
Very goob, I'll see if it works tomorrow Update: Yeah, that did the trick! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Video cutscenes were actually already supported in Polymod, but you needed to specify the absolute path to the MP4 since Paths() didn't work (see #2446).
PR looks good to me, though!
Zip mods couldn't load videos in any way, now if these changes are pushed that will be a no problem. |
I see, interesting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure I heard once that hxvlc is much better than hxCodec so this is good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes please
will have to do R&D on this internally and do some battle testing! but been seeing you work away at hxvlc while we been on old hxcodec ! |
on my macbook (havent been at my home windows pc yet) I seem to be getting
this also occurs with darnell, i just tried to open week 7 and weekend 1 from story menu |
You need to do a clean build to delete the old plugins |
I updated libvlc recently but dw, i made a patch were it will automatically fix this issue. |
I'll need to release it tomorrow. |
FYI The repo now uses |
nooo why closed? i was really looking forward to this one as it fixes several issues ive encountered with videos |
I don't think this was ever going to be pushed, fell free to make a pr on your own if you want. |
To be fair there are a lot of older PRs that still have the |
By using
hxvlc
,bitstream
playback is available, allowing video cutscenes to be played directly from byte streams. This enables video cutscenes to be played from polymod.