Fix wrong notes being removed from notesB

FunkinCrew · Oct 7, 2024 · 232bafd · 232bafd
1 parent d9c455e
commit 232bafd
Showing 1 changed file with 12 additions and 7 deletions.
diff --git a/source/funkin/ui/debug/charting/util/NoteDataFilter.hx b/source/funkin/ui/debug/charting/util/NoteDataFilter.hx
@@ -80,30 +80,37 @@ class NoteDataFilter
   {
     // TODO: Maybe this whole function should be moved to SongNoteDataArrayTools
     var result:Array<SongNoteData> = notesA.copy();
+    var overlappingNotes:Array<SongNoteData> = [];
 
     for (noteB in notesB)
     {
-      var overlaps:Bool = false;
+      var hasOverlap:Bool = false;
 
       for (noteA in notesA)
       {
         if (doNotesStack(noteA, noteB, threshold))
         {
-          overlaps = true;
+          hasOverlap = true;
           break;
         }
       }
 
-      if (!overlaps)
+      if (!hasOverlap)
       {
         result.push(noteB);
       }
       else if (modifyB)
       {
-        notesB.remove(noteB);
+        overlappingNotes.push(noteB);
       }
     }
 
+    if (modifyB)
+    {
+      for (note in overlappingNotes)
+        notesB.remove(note);
+    }
+
     return result;
   }
 
@@ -113,8 +120,6 @@ class NoteDataFilter
    */
   static inline function doNotesStack(noteA:SongNoteData, noteB:SongNoteData, threshold:Float):Bool
   {
-    return noteA.getStrumlineIndex() == noteB.getStrumlineIndex()
-      && noteA.getDirection() == noteB.getDirection()
-      && Math.abs(noteA.time - noteB.time) <= threshold;
+    return noteA.data == noteB.data && Math.abs(noteA.time - noteB.time) <= threshold;
   }
 }