Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: favour .ts over .d.ts files in @fuel-ts/abi-typegen #3680

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

petertonysmith94
Copy link
Contributor

Summary

  • The .d.ts files don't get bundled into the final distribution for @fuel-ts/recipes. This change will rename all .d.ts files to .ts before building the package out for distribution.
Before After
Screenshot 2025-02-07 at 16 34 41 image

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 added bug Issue is a bug chore Issue is a chore labels Feb 7, 2025
@petertonysmith94 petertonysmith94 self-assigned this Feb 7, 2025
Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 8:26am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 8:26am
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 8:26am

@petertonysmith94 petertonysmith94 removed the chore Issue is a chore label Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Coverage Report:

Lines Branches Functions Statements
77.09%(-0.06%) 70.69%(+0%) 75.18%(-0.12%) 77.09%(-0.06%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94 petertonysmith94 marked this pull request as ready for review February 7, 2025 17:48
packages/recipes/scripts/build-recipes.ts Outdated Show resolved Hide resolved
@@ -5,7 +5,7 @@
/* eslint-disable @typescript-eslint/consistent-type-imports */

/*
Fuels version: 0.97.2
Fuels version: 0.99.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petertonysmith94 This is unrelated to this PR, but we still need to fix this — these files must be re-generated and committed in CI right after a version bump.

cc @nedsalk

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petertonysmith94 petertonysmith94 changed the title fix: correctly bundle @fuel-ts/recipes files fix: favour .ts over .d.ts files in @fuel-ts/abi-typegen Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants