-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: remove deprecated submitAndAwait
operation
#3548
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please could you add a change to the breaking change notes, detailing what should be used now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For breaking change notes, could we have something like this so it's more inline with other breaking change notes?
Breaking Changes
Provider.operations.submitAndAwait
has been removed, since being deprecated in #3101. Please now useProvider.operations.submitAndAwaitStatus
to perform this functionality. If you are interested in the deprecation/removal reasons, please refer to FuelLabs/fuel-core#2108.// before const response = await provider.operations.submitAndAwait(txRequest); // after const response = await provider.operations.submitAndAwaitStatus(txRequest);
6631b41
Coverage Report:
Changed Files:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but question - should the method be removed from the fuel-core-schema.graphql
as well? I understand the method still exists in fuel-core
but if it's no longer used on our side I wonder why it ought to be included here.
The schema ( |
@petertonysmith94 I understand that aspect - the question was more in relation to why do we need to have an identical file on our side if we are not using all the methods, particularly if we are removing one. |
submitAndAwait
from provider #3518Summary
This PR removes the
submitAndAwait
operation which was previously deprecated.Breaking Changes
submitAndAwait
operation was removedAfter being deprecated since #3101, we have removed this operation altogether. Please use the
submitAndAwaitStatus
method instead which gives the same results assubmitAndAwait
. If you are interested in the deprecation/removal reasons, please refer to FuelLabs/fuel-core#2108.Checklist