Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: removed network URLs #3532

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Jan 3, 2025

Release notes

In this release, we:

  • Removed network URLs for devnet and testnet

Summary

  • Removed network URLs
    • DEVNET_NETWORK_URL
    • TESTNET_NETWORK_URL

Breaking Changes

  • Removed network URLs for devnet and testnet in favour of user defined strings
// Before
import { DEVNET_NETWORK_URL, TESTNET_NETWORK_URL } from 'fuels';

// After
const  DEVNET_NETWORK_URL = 'https://devnet.fuel.network/v1/graphql';
const  TESTNET_NETWORK_URL = 'https://testnet.fuel.network/v1/graphql';

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 added the chore Issue is a chore label Jan 3, 2025
@petertonysmith94 petertonysmith94 self-assigned this Jan 3, 2025
Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 10:17am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 10:17am
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 10:17am

@petertonysmith94 petertonysmith94 changed the title chore: removed network URLs chore!: removed network URLs Jan 3, 2025
@arboleya
Copy link
Member

arboleya commented Jan 3, 2025

It's not a request; I'm just thinking out loud, but I still think there's space for these constants.

@petertonysmith94
Copy link
Contributor Author

It's not a request; I'm just thinking out loud, but I still think there's space for these constants.

For me, I'd favour using environmental variables for network dependant constants, but I can see how these constants could be handy. I'm happy to un-deprecate, if you have a strong opinion.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Coverage Report:

Lines Branches Functions Statements
77.77%(-0.01%) 70.4%(+0%) 75.37%(-0.01%) 77.74%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.57%
(+0%)
76.71%
(-1.37%)
84%
(+0%)
88.81%
(+0%)
🔴 packages/create-fuels/src/lib/getPackageManager.ts 100%
(+0%)
88.88%
(+8.88%)
100%
(+0%)
100%
(+0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove network URLs
2 participants