Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable usage of 0 port for the fuelCorePort field #3528

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

fix: enable usage of 0 port for the fuelCorePort field #3528

wants to merge 14 commits into from
+65 −30

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented Jan 3, 2025 •
edited
Loading

Summary

The autoStartFuelCore function wasn't using the provider url returned by launchNode but was rather constructing its own url, which led to the inability to use the ephemeral port 0 because it'd construct an invalid http://127.0.0.1:0/v1/graphql url.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@nedsalk nedsalk added the bug Issue is a bug label Jan 3, 2025
@nedsalk nedsalk self-assigned this Jan 3, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 2:07pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 2:07pm
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 2:07pm

@nedsalk nedsalk marked this pull request as ready for review January 3, 2025 09:25
@nedsalk nedsalk marked this pull request as draft January 3, 2025 09:33
@nedsalk nedsalk mentioned this pull request Jan 3, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees

@nedsalk nedsalk

Labels
bug Issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for fuelCorePort: 0 in fuels.config.ts
1 participant
@nedsalk