-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: making provider
initialization sync
again
#3514
Open
arboleya
wants to merge
33
commits into
master
Choose a base branch
from
aa/feat/sync-provider-init
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+919
−797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
arboleya
requested review from
digorithm,
Torres-ssf,
Dhaiwat10,
danielbate,
nedsalk,
petertonysmith94 and
maschad
as code owners
January 1, 2025 11:06
nedsalk
reviewed
Jan 1, 2025
petertonysmith94
previously approved these changes
Jan 2, 2025
nedsalk
previously approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
nedsalk
approved these changes
Jan 2, 2025
Coverage Report:
Changed Files:
|
petertonysmith94
approved these changes
Jan 3, 2025
danielbate
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provider
initializationsync
again #3509Release notes
In this release, we:
Provider
constructorpublic
andsync
againSummary
The first implementation got it backward, but now things are back in place:
sync
andpublic
againasync
(like they should)Oneliners help to show why
async
initialization isn't good — look at the awkward parenthesis we must use to isolate the call before other methods (the actualasync
ones) can be chained.Breaking Changes
1.
Provider
Instantiationasync
tosync
2.
Provider
methodsasync
3.
TransferParams
andContractTransferParams
assetId
is now required byTransferParams
andContractTransferParams
4. Transaction Response
chainId
Checklist