-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unable to kill fuels dev
with pnpm
#3508
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This PR is published in NPM with version 0.0.0-pr-3508-20241230183927 |
CodSpeed Performance ReportMerging #3508 will degrade performances by 47.96%Comparing Summary
Benchmarks breakdown
|
…/fuels-ts into ps/fix/unable-to-kill-fuels-dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need tests for both issues the PR is closing (#2889, #3479).
You can find a test for #2889 in #3038. The same infrastructure in that test can be used for this PR. An approach could be to use a modified version of runInit
where one would add a "fuels:dev": "fuels dev"
script into the package.json
file and then run a detached spawn('pnpm fuels:dev')
command. This should simulate the same behavior that we do manually when testing with releases of PRs.
Coverage Report:
Changed Files:
|
fuels:dev
process when usingpnpm
#3479fuels dev
withCTRL+C
(SIGINT
) doesn't killfuel-core
node #2889Summary
fuels dev
not exiting on a single Ctrl + C forpnpm
.npm
,pnpm
andbun
. (0.0.0-pr-3508-20241230183927
)Checklist