Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve punycode deprecation notice #2908

Closed
wants to merge 2 commits into from
Closed

fix: resolve punycode deprecation notice #2908

wants to merge 2 commits into from

Conversation

arboleya
Copy link
Member

Summary

Upgraded problematic dependency-of-dependency via overrides to address deprecation notice.

Checklist

  • I added — tests to prove my changes
  • I updated — all the necessary docs
  • I reviewed — the entire PR myself, using the GitHub UI
  • I described — all breaking changes and the Migration Guide

@arboleya arboleya added the chore Issue is a chore label Aug 10, 2024
@arboleya arboleya self-assigned this Aug 10, 2024
@arboleya arboleya enabled auto-merge (squash) August 10, 2024 15:58
@arboleya arboleya changed the title Overriding node-fetch’s internal whatwg-url dependency fix: resolve punycode deprecation noticed Aug 10, 2024
@github-actions github-actions bot added the bug Issue is a bug label Aug 10, 2024
@arboleya arboleya removed the bug Issue is a bug label Aug 10, 2024
maschad
maschad requested changes Aug 10, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arboleya I'm still getting this error when building the account and the docs packages, I ran install and build, am I missing something here?

Screenshot 2024-08-10 at 2 39 11 PM Screenshot 2024-08-10 at 2 38 43 PM

@arboleya arboleya marked this pull request as draft August 11, 2024 13:04
auto-merge was automatically disabled August 11, 2024 13:04

Pull request was converted to draft

@arboleya arboleya changed the title fix: resolve punycode deprecation noticed fix: resolve punycode deprecation notice Aug 11, 2024
@github-actions github-actions bot added the bug Issue is a bug label Aug 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.76%(+0%) 72.16%(+0%) 77.81%(+0%) 79.9%(+0%)
Changed Files:

Coverage values did not change👌.

@arboleya arboleya closed this Aug 15, 2024
@arboleya arboleya deleted the aa/chore/fix-deprecation-notice branch August 15, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maschad maschad maschad requested changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

Assignees

@arboleya arboleya

Labels
bug Issue is a bug chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix punycode deprecation notice
2 participants
@arboleya @maschad