Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mimic JsonAbi interface from abi-coder in abi-typegen #2743

Merged
merged 13 commits into from
Jul 11, 2024

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented Jul 10, 2024

Summary

This PR serves two purposes:

  1. A step towards Merge abi-coder and abi-typegen packages #2346
  2. A step towards Adapt ABI format to new specification #2313 for easier reviewing when changes to JsonAbi happen. It would be more difficult to review the changes when the names of the interfaces are different.

This PR only contains renaming and moving of abi-typegen interfaces to match the naming and importing pattern from abi-coder. It contains no new features.

Checklist

  • I addedtests to prove my changes
  • I updated — all the necessary docs
  • I reviewed — the entire PR myself, using the GitHub UI
  • I described — all breaking changes and the Migration Guide

@nedsalk nedsalk added the chore Issue is a chore label Jul 10, 2024
@nedsalk nedsalk self-assigned this Jul 10, 2024
@nedsalk nedsalk marked this pull request as ready for review July 10, 2024 08:49
@nedsalk nedsalk added this to the 0.x mainnet milestone Jul 10, 2024
@nedsalk nedsalk mentioned this pull request Jul 10, 2024
4 tasks
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.41%(+0%) 71.67%(+0%) 77.03%(+0%) 79.48%(+0%)
Changed Files:

Coverage values did not change👌.

Copy link
Member

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@nedsalk nedsalk merged commit 968ad03 into master Jul 11, 2024
19 checks passed
@nedsalk nedsalk deleted the ns/chore/share-interfaces-abi branch July 11, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants