Add a binary to extract data from fuel-core #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 22, 2024
xgreenx
reviewed
Feb 22, 2024
|
|
||
| let mut tx_data: Vec<Transaction> = vec![]; | ||
| let mut tx_extra: Vec<TxExtra> = vec![]; | ||
| for id in &block.transactions { |
There was a problem hiding this comment.
Requesting all transactions one by one will be very slow and expensive=)
It is better to request all information in one request. You can check how it was done on the indexer side https://github.com/FuelLabs/fuel-indexer/pull/969/files
| let mut height: BlockHeight = opt.height.into(); | ||
|
|
||
| loop { | ||
| if let Some(block) = client.block_by_height(height.into()).await? { |
There was a problem hiding this comment.
Also fuel-core support PaginatedResult, so it would be better to request a lot of blocks at the same time
There was a problem hiding this comment.
We mainly poll for the latest block, but it still probably makes sense for pulling the old blocks.
Salka1988
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated from
fuel-core, as this is fully indepdendent and only using the GraphQL API. Should be compatible withfuel-coreversions ranging from0.21.0used by Beta-5 network, to the latest master at FuelLabs/fuel-core@ed92738I'm not sure if I'm supposed to regenerate the go files here, or do we do that in a separate PR?
Nice to have things, possible follow-up PRs:
The crate is currently missing license field on
Cargo.toml. Is it ok to license this under Apache-2, or do we need BSL here @xgreenx?