Allow empty tag list #553
Merged
Allow empty tag list #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
approved these changes
Jan 20, 2024
There was a problem hiding this comment.
thanks, makes sense to do it like that.
lets make it consistent though: TagCapable is implemented by many clients. lets document on the interface that an empty tag list is ignored, and fix all the other clients as well. can you adjust that?
and can you please add a changelog entry for it, so people are aware of it?
|
@dbu done |
dbu
reviewed
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
array_chunk(): Argument #2 ($length) must be greater than 0and removes the need for redundant boilerplateifeverywhere.