Open
Conversation
36d0132 to
fdbff70
Compare
592303d to
bc16482
Compare
* feat: add generating of matrix
bc16482 to
02bf568
Compare
Member
|
Mh, I have been thinking, but I think I am not yet ready to drop support for the Shopware Images < 6.4.6 images, although the supported PHP versions are not provided with security Updates anymore. This is due to the fact, that we sometimes still publish plugin updates for Shopware 6.4.x and therefore want to run the tests and probably also have an up to date But I will have a more careful look at the PR (hopefully soon) :-) and clean it up/rebase it and merge it. |
Member
Author
|
@aragon999 thank you. but you are able to build with a newer shopware version, aren‘t you? 🤔 |
Member
|
Yes but I cannot run the tests :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, this small PR escalated quickly 🙈
Due to the support end of PHP 7.4 and 8.0, we should not waste energy on these things :-)
INFO: 8,3 fails, while there is no one published yet because it is introduced here, too.