Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Leoteles
Copy link

@Leoteles Leoteles commented Mar 6, 2021

1)When extracting 'Starting 11' events from event list, the result was not following the match_id order, and not any chronological order (like match_game or date)
As an exaple of the error:
In team.matches(for w==1), match_id n. 19758 happens only after match_id 19806.
But in events.list, match_id 19758 is after 19757. This list is ordered by id and not by date(or match_week). Thus, the error
This was fixed by imposing the order of the results to the order selected previously(match_date, or match_week).

2)Added dependencies: dplyr, ggplot

3)%!in% is now defined

4)The match week does not follow chronological order. So, it is best to sort by match date

1)When extracting 'Starting 11' events from event list, the result was not following the match_id order, and not any chronological order (like match_game or date)
As an exaple of the error:
In team.matches(for w==1), match_id n. 19758 happens only after match_id 19806.
But in events.list, match_id 19758 is after 19757. This list is ordered by id and not by date(or match_week). Thus, the error
This was fixed by imposing the order of the results to the order selected previously.
  
2)Added dependencies: dplyr, ggplot

3)%!in% is now defined
 
4)The match week does not follow chronological order. So, it is best to sort by match date
@Leoteles
Copy link
Author

Leoteles commented Mar 6, 2021

The R code sent by Sudarshan is a blessing to the community.
Here I sugest some adjustments, mainly on line 156 (... which(names(event.list) %in% team.matches$match_id)
The result of this command follows the order of event.list, and not team.matches, losing the previously established math week order (here I also suggest using match date).
As a consequence, the rotation calculation gets compromised.

Other minor suggestions include importing needed library.

Cheers,
Leonardo Carvalho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant