Skip to content

Commit

Permalink
* Remove comment auto load setting
Browse files Browse the repository at this point in the history
  • Loading branch information
PikachuEXE committed Apr 15, 2024
1 parent 020f991 commit c5f0a8c
Show file tree
Hide file tree
Showing 47 changed files with 5 additions and 114 deletions.
10 changes: 0 additions & 10 deletions src/renderer/components/player-settings/player-settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -197,10 +197,6 @@ export default defineComponent({
return this.$store.getters.getScreenshotFilenamePattern
},

commentAutoLoadEnabled: function () {
return this.$store.getters.getCommentAutoLoadEnabled
},

hideComments: function () {
return this.$store.getters.getHideComments
},
Expand All @@ -209,11 +205,6 @@ export default defineComponent({
screenshotFolder: function() {
this.getScreenshotFolderPlaceholder()
},
hideComments: function(newValue) {
if (newValue) {
this.updateCommentAutoLoadEnabled(false)
}
}
},
mounted: function() {
this.getScreenshotFolderPlaceholder()
Expand Down Expand Up @@ -317,7 +308,6 @@ export default defineComponent({
'updateScreenshotFolderPath',
'updateScreenshotFilenamePattern',
'parseScreenshotCustomFileName',
'updateCommentAutoLoadEnabled',
])
}
})
8 changes: 0 additions & 8 deletions src/renderer/components/player-settings/player-settings.vue
Original file line number Diff line number Diff line change
Expand Up @@ -255,14 +255,6 @@
</ft-flex-box>
<br>
</div>
<ft-flex-box>
<ft-toggle-switch
:label="$t('Settings.Player Settings.Comment Auto Load.Comment Auto Load')"
:default-value="commentAutoLoadEnabled"
:disabled="hideComments"
@change="updateCommentAutoLoadEnabled"
/>
</ft-flex-box>
</ft-settings-section>
</template>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,6 @@ export default defineComponent({
return this.$store.getters.getHideCommentPhotos
},

commentAutoLoadEnabled: function () {
return this.$store.getters.getCommentAutoLoadEnabled
},

sortNames: function () {
return [
this.$t('Comments.Top comments'),
Expand All @@ -89,7 +85,7 @@ export default defineComponent({
return this.$store.getters.getGeneralAutoLoadMorePaginatedItemsEnabled
},
observeVisibilityOptions: function () {
if (!(this.commentAutoLoadEnabled || this.generalAutoLoadMorePaginatedItemsEnabled)) {
if (!this.generalAutoLoadMorePaginatedItemsEnabled) {
return false
}
if (!this.videoPlayerReady) { return false }
Expand All @@ -100,7 +96,7 @@ export default defineComponent({
// No point doing anything if not visible
if (!isVisible) { return }
// It's possible the comments are being loaded/already loaded
if (this.canPerformInitialCommentLoading && this.commentAutoLoadEnabled) {
if (this.canPerformInitialCommentLoading) {
this.getCommentData()
} else if (this.canPerformMoreCommentLoading) {
this.getMoreComments()
Expand Down
1 change: 0 additions & 1 deletion src/renderer/store/modules/settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,6 @@ const state = {
fetchSubscriptionsAutomatically: true,
settingsPassword: '',
allowDashAv1Formats: false,
commentAutoLoadEnabled: false,
useDeArrowTitles: false,
useDeArrowThumbnails: false,
deArrowThumbnailGeneratorUrl: 'https://dearrow-thumb.ajay.app',
Expand Down
2 changes: 0 additions & 2 deletions static/locales/ar.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -381,8 +381,6 @@ Settings:
Enter Fullscreen on Display Rotate: وضع ملء الشاشة عند تدوير الشاشة
Skip by Scrolling Over Video Player: تخطي بالتمرير فوق مشغل الفيديو
Allow DASH AV1 formats: السماح بتنسيقات DASH AV1
Comment Auto Load:
Comment Auto Load: تحميل التلقائي للتعليقات
Privacy Settings:
Privacy Settings: 'إعدادات الخصوصية'
Remember History: 'تذّكر سجلّ المشاهدة'
Expand Down
2 changes: 0 additions & 2 deletions static/locales/be.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -291,8 +291,6 @@ Settings:
Error:
Forbidden Characters: ''
Empty File Name: ''
Comment Auto Load:
Comment Auto Load: ''
External Player Settings:
External Player Settings: ''
External Player: ''
Expand Down
2 changes: 0 additions & 2 deletions static/locales/bg.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -397,8 +397,6 @@ Settings:
Enter Fullscreen on Display Rotate: Режим на цял екран при завъртане на дисплея
Skip by Scrolling Over Video Player: Превъртане над видео плейъра
Allow DASH AV1 formats: Разрешаване на форматите DASH AV1
Comment Auto Load:
Comment Auto Load: Атоматично зареждане на коментари
Privacy Settings:
Privacy Settings: 'Настройки за поверителност'
Remember History: 'Запазване на историята'
Expand Down
2 changes: 0 additions & 2 deletions static/locales/ckb.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,6 @@ Settings:
Error:
Forbidden Characters: ''
Empty File Name: ''
Comment Auto Load:
Comment Auto Load: ''
External Player Settings:
External Player Settings: 'ڕێکخستنەکانی لێدەری دەرەکی'
External Player: 'لێدەری دەرەکی'
Expand Down
2 changes: 0 additions & 2 deletions static/locales/cs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,8 +394,6 @@ Settings:
Enter Fullscreen on Display Rotate: Při otočení displeje přejít na celou obrazovku
Skip by Scrolling Over Video Player: Posouvat čas posuvem kolečka myši na přehrávači
Allow DASH AV1 formats: Povolit formáty DASH AV1
Comment Auto Load:
Comment Auto Load: Automaticky načítat komentáře
Privacy Settings:
Privacy Settings: 'Nastavení soukromí'
Remember History: 'Zapamatovat historii'
Expand Down
2 changes: 0 additions & 2 deletions static/locales/cy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -298,8 +298,6 @@ Settings:
Error:
Forbidden Characters: 'Nodau Gwahardd'
Empty File Name: ''
Comment Auto Load:
Comment Auto Load: ''
External Player Settings:
External Player Settings: ''
External Player: 'Chwaraewr Allanol'
Expand Down
2 changes: 0 additions & 2 deletions static/locales/da.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -364,8 +364,6 @@ Settings:
Scroll Playback Rate Over Video Player: Scroll Afspilningshastighed i Videoafspiller
Scroll Volume Over Video Player: Scroll Lydstyrke i Videoafspiller
Skip by Scrolling Over Video Player: Spring Over ved at Scrolle Over Videoafspilleren
Comment Auto Load:
Comment Auto Load: Kommentar Auto-Indlæs
Allow DASH AV1 formats: Tillad DASH AV1-formater
Privacy Settings:
Privacy Settings: 'Privatlivsindstillinger'
Expand Down
2 changes: 0 additions & 2 deletions static/locales/de-DE.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -400,8 +400,6 @@ Settings:
Enter Fullscreen on Display Rotate: Beim Drehen des Bildschirms zu Vollbild wechseln
Skip by Scrolling Over Video Player: Überspringen durch Scrollen über den Videoabspieler
Allow DASH AV1 formats: DASH AV1-Formate zulassen
Comment Auto Load:
Comment Auto Load: Kommentare automatisch laden
Subscription Settings:
Subscription Settings: Abo-Einstellungen
Hide Videos on Watch: Videos bei Wiedergabe ausblenden
Expand Down
2 changes: 0 additions & 2 deletions static/locales/el.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -305,8 +305,6 @@ Settings:
Enter Fullscreen on Display Rotate: Μετάβαση στην Πλήρη Οθόνη κατά την Περιστροφή
Οθόνης
Allow DASH AV1 formats: Να επιτρέπονται οι μορφές DASH AV1
Comment Auto Load:
Comment Auto Load: Αυτόματη Φόρτωση Σχολίων
Privacy Settings:
Privacy Settings: 'Ρυθμίσεις απορρήτου'
Remember History: 'Διατήρηση ιστορικού'
Expand Down
4 changes: 1 addition & 3 deletions static/locales/en-US.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ Settings:
Enable Search Suggestions: Enable Search Suggestions
Auto Load Next Page:
Label: Auto Load Next Page
Tooltip: This does NOT handle video comment auto load
Tooltip: This also handles video comment auto load
Default Landing Page: Default Landing Page
Locale Preference: Locale Preference
System Default: System Default
Expand Down Expand Up @@ -399,8 +399,6 @@ Settings:
Error:
Forbidden Characters: Forbidden Characters
Empty File Name: Empty File Name
Comment Auto Load:
Comment Auto Load: Comment Auto Load
External Player Settings:
External Player Settings: External Player Settings
External Player: External Player
Expand Down
2 changes: 0 additions & 2 deletions static/locales/en_GB.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -389,8 +389,6 @@ Settings:
File Name Label: Filename pattern
Skip by Scrolling Over Video Player: Skip by scrolling over video player
Allow DASH AV1 formats: Allow DASH AV1 formats
Comment Auto Load:
Comment Auto Load: Comment auto load
External Player Settings:
External Player Settings: External Player Settings
External Player: External Player
Expand Down
2 changes: 0 additions & 2 deletions static/locales/es.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -396,8 +396,6 @@ Settings:
Skip by Scrolling Over Video Player: Omitir al desplazarse sobre el reproductor
de vídeo
Allow DASH AV1 formats: Permitir formatos DASH AV1
Comment Auto Load:
Comment Auto Load: Cargar los comentarios automáticamente
Privacy Settings:
Privacy Settings: 'Ajustes de Privacidad'
Remember History: 'Recordar historial'
Expand Down
2 changes: 0 additions & 2 deletions static/locales/es_AR.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,6 @@ Settings:
Allow DASH AV1 formats: Permitir formatos DASH AV1
Scroll Playback Rate Over Video Player: Acelerar video con la rueda del mouse
Fast-Forward / Rewind Interval: Período de Avance Rápido / Retroceso
Comment Auto Load:
Comment Auto Load: Cargar los comentarios automáticamente
Video Playback Rate Interval: Intervalo entre velocidades del video
Max Video Playback Rate: Velocidad máxima de reproducción de video
Enter Fullscreen on Display Rotate: Cambiar a pantalla completa al girar la pantalla
Expand Down
2 changes: 0 additions & 2 deletions static/locales/et.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -391,8 +391,6 @@ Settings:
Skip by Scrolling Over Video Player: Jäta vahele, kerides üle videopleieri
Allow DASH AV1 formats: Luba DASH AV1 vormingud
Enter Fullscreen on Display Rotate: Ekraani pööramisel ava täisekraanivaade
Comment Auto Load:
Comment Auto Load: Laadi kommentaarid automaatselt
Privacy Settings:
Privacy Settings: 'Privaatsuse seadistused'
Remember History: 'Jäta ajalugu meelde'
Expand Down
2 changes: 0 additions & 2 deletions static/locales/eu.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -391,8 +391,6 @@ Settings:
Display Play Button In Video Player: Bistaratu Erreproduzitzeko botoia bideo erreproduzitzailean
Max Video Playback Rate: Gehienezko bideoen erreprodukzio-tasa
Video Playback Rate Interval: Bideo Erreprodukzio-tasa tartea
Comment Auto Load:
Comment Auto Load: Iruzkin karga automatikoa
Skip by Scrolling Over Video Player: Saltatu bideo-erreproduzitzailean korrituz
Enter Fullscreen on Display Rotate: Sartu pantaila osoko pantaila biratu pantailan
Allow DASH AV1 formats: Baimendu DASH AV1 formatuak
Expand Down
2 changes: 0 additions & 2 deletions static/locales/fa.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,6 @@ Settings:
پخش کننده ویدیو
Video Playback Rate Interval: فاصله سرعت پخش ویدیو
Max Video Playback Rate: حداکثر سرعت پخش ویدیو
Comment Auto Load:
Comment Auto Load: نظرات اتوماتیک بارگذاری شود
Enter Fullscreen on Display Rotate: در چرخه نمایشگر وارد صفحه تمام صفحه شوید
Screenshot:
Format Label: فرمت اسکرین شات
Expand Down
2 changes: 0 additions & 2 deletions static/locales/fi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -347,8 +347,6 @@ Settings:
Enter Fullscreen on Display Rotate: Siirry koko näytön tilaan näyttöä kiertäessä
Skip by Scrolling Over Video Player: Ohita vierittämällä videosoittimen yli
Allow DASH AV1 formats: Salli DASH AV1 -formaatit
Comment Auto Load:
Comment Auto Load: Kommenttien automaattinen lataus
Subscription Settings:
Subscription Settings: 'Tilausasetukset'
Hide Videos on Watch: 'Piilota katsotut videot'
Expand Down
2 changes: 0 additions & 2 deletions static/locales/fr-FR.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -410,8 +410,6 @@ Settings:
Enter Fullscreen on Display Rotate: Entrer en plein écran sur l'affichage Rotation
Skip by Scrolling Over Video Player: Sauter en faisant défiler le lecteur vidéo
Allow DASH AV1 formats: Autoriser les formats DASH AV1
Comment Auto Load:
Comment Auto Load: Chargement automatique des commentaires
Subscription Settings:
Subscription Settings: 'Paramètres des abonnements'
Hide Videos on Watch: 'Masquer les vidéos visionnées'
Expand Down
2 changes: 0 additions & 2 deletions static/locales/he.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -291,8 +291,6 @@ Settings:
Enter Fullscreen on Display Rotate: מעבר למסך מלא עם סיבוב התצוגה
Skip by Scrolling Over Video Player: אפשר לדלג על ידי גלילה על נגן הווידאו
Allow DASH AV1 formats: לאפשר תצורות DASH AV1
Comment Auto Load:
Comment Auto Load: טעינת תגובות אוטומטית
Privacy Settings:
Privacy Settings: 'הגדרות פרטיות'
Remember History: 'לזכור את היסטוריית הצפייה'
Expand Down
2 changes: 0 additions & 2 deletions static/locales/hr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -384,8 +384,6 @@ Settings:
ekrana
Skip by Scrolling Over Video Player: Preskoči pomicanjem preko video playera
Allow DASH AV1 formats: Dozvoli DASH AV1 formate
Comment Auto Load:
Comment Auto Load: Automatski učitaj komentare
Privacy Settings:
Privacy Settings: 'Postavke privatnosti'
Remember History: 'Zapamti povijest'
Expand Down
2 changes: 0 additions & 2 deletions static/locales/hu.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -405,8 +405,6 @@ Settings:
Enter Fullscreen on Display Rotate: Teljes képernyős mód a kijelzőn forgatáshoz
Skip by Scrolling Over Video Player: Kihagyás a Videolejátszó felett görgetve
Allow DASH AV1 formats: DASH AV1 formátumok engedélyezése
Comment Auto Load:
Comment Auto Load: Megjegyzés automatikus betöltése
Privacy Settings:
Privacy Settings: 'Adatvédelmi beállítások'
Remember History: 'Előzmények megjegyzése'
Expand Down
2 changes: 0 additions & 2 deletions static/locales/id.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -262,8 +262,6 @@ Settings:
Quality Label: Kualitas Tangkapan Layar
File Name Label: Pola Nama Berkas
Allow DASH AV1 formats: Izinkan format DASH AV1
Comment Auto Load:
Comment Auto Load: Muat Otomatis Komentar
Privacy Settings:
Privacy Settings: 'Pengaturan Privasi'
Remember History: 'Ingat Riwayat'
Expand Down
2 changes: 0 additions & 2 deletions static/locales/is.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -398,8 +398,6 @@ Settings:
Enter Fullscreen on Display Rotate: Fara í skjáfylli við snúning á skjá
Skip by Scrolling Over Video Player: Sleppa með því að skruna ofan á myndspilara
Allow DASH AV1 formats: Leyfa DASH AV1 snið
Comment Auto Load:
Comment Auto Load: Hlaða sjálfkrafa inn athugasemdum
Privacy Settings:
Privacy Settings: 'Stillingar gagnaleyndar'
Remember History: 'Muna áhorfsferil'
Expand Down
2 changes: 0 additions & 2 deletions static/locales/it.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -394,8 +394,6 @@ Settings:
Enter Fullscreen on Display Rotate: Entra a schermo intero su Ruota schermo
Skip by Scrolling Over Video Player: Salta tramite scorrimento sul lettore video
Allow DASH AV1 formats: Consenti formati DASH AV1
Comment Auto Load:
Comment Auto Load: Carica automaticamente i commenti
Privacy Settings:
Privacy Settings: 'Impostazioni della privacy'
Remember History: 'Salva la cronologia'
Expand Down
6 changes: 2 additions & 4 deletions static/locales/ja.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ Playlists: '再生リスト'
User Playlists:
Your Playlists: 'あなたの再生リスト'
Your saved videos are empty. Click on the save button on the corner of a video to have it listed here: 保存した動画はありません。一覧に表示させるには、ビデオの角にある保存ボタンをクリックします
Playlist Message:
Playlist Message:
このページは、完全に動作する動画リストではありません。保存またはお気に入りと設定した動画のみが表示されます。操作が完了すると、現在ここにあるすべての動画は「お気に入り」の動画リストに移動します。
Search bar placeholder: 動画リスト内の検索
Empty Search Message: この再生リストに、検索に一致する動画はありません
Expand Down Expand Up @@ -281,8 +281,6 @@ Settings:
Enter Fullscreen on Display Rotate: 横画面時にフルスクリーンにする
Skip by Scrolling Over Video Player: 動画プレーヤーでスクロールしてスキップ可能にする
Allow DASH AV1 formats: DASH AV1形式を許可
Comment Auto Load:
Comment Auto Load: コメント自動読み込み
Subscription Settings:
Subscription Settings: '登録チャンネルの設定'
Hide Videos on Watch: '視聴済み動画の非表示'
Expand Down Expand Up @@ -469,7 +467,7 @@ Settings:
Experimental Settings:
Replace HTTP Cache: HTTP キャッシュの置換
Experimental Settings: 実験中の設定
Warning:
Warning:
これらの設定は実験的なものであり、有効にするとアプリのクラッシュを引き起こす恐れがあります。バックアップをとっておくことを強くお勧めします。自己責任で使用してください!
Password Settings:
Password Settings: パスワード設定
Expand Down
2 changes: 0 additions & 2 deletions static/locales/lt.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,6 @@ Settings:
Max Video Playback Rate: Maksimalus vaizdo įrašų atkūrimo dažnis
Enter Fullscreen on Display Rotate: Viso ekrano režimas pasukus ekraną
Skip by Scrolling Over Video Player: Praleiskite slinkdami per vaizdo grotuvą
Comment Auto Load:
Comment Auto Load: Komentuoti Automatinis įkėlimas
Allow DASH AV1 formats: Leisti DASH AV1 formatus
External Player Settings:
External Player Settings: 'Išorinio grotuvo nustatymai'
Expand Down
2 changes: 0 additions & 2 deletions static/locales/lv.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -293,8 +293,6 @@ Settings:
Error:
Forbidden Characters: 'Aizliegtās rakstzīmes'
Empty File Name: 'Tukšs datnes nosaukums'
Comment Auto Load:
Comment Auto Load: 'Komentāru autoielāde'
External Player Settings:
External Player Settings: 'Ārējā atskaņotāja iestatījumi'
External Player: 'Ārējais atskaņotājs'
Expand Down
2 changes: 0 additions & 2 deletions static/locales/nb_NO.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,6 @@ Settings:
Enter Fullscreen on Display Rotate: Fullskjermsvisning når skjermen roteres
Skip by Scrolling Over Video Player: Hopp over ved å rulle over videoavspiller
Allow DASH AV1 formats: Tillat DASH AV1-formater
Comment Auto Load:
Comment Auto Load: Auto-innlasting av kommentarer
Privacy Settings:
Privacy Settings: 'Personvernsinnstillinger'
Remember History: 'Husk historikk'
Expand Down
2 changes: 0 additions & 2 deletions static/locales/nl.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -388,8 +388,6 @@ Settings:
%s tweecijferige seconde in de video; %t driecijferige milliseconde in de
video; %i ID van de video. U kunt ook "\" of "/" gebruiken om deelmappen aan
te maken.'
Comment Auto Load:
Comment Auto Load: Commentaar Automatisch Laden
Skip by Scrolling Over Video Player: Overslaan door over de videospeler te scrollen
Allow DASH AV1 formats: DASH-AV1-bestandstypes toestaan
Enter Fullscreen on Display Rotate: Volledig scherm bij draaien van scherm
Expand Down
2 changes: 0 additions & 2 deletions static/locales/pl.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -393,8 +393,6 @@ Settings:
Skip by Scrolling Over Video Player: Przewijaj film kółkiem myszy na obszarze
odtwarzacza
Allow DASH AV1 formats: Zezwól na format AV1 DASH
Comment Auto Load:
Comment Auto Load: Ładuj komentarze automatycznie
Subscription Settings:
Subscription Settings: 'Ustawienia subskrypcji'
Hide Videos on Watch: 'Ukrywaj filmy po obejrzeniu'
Expand Down
2 changes: 0 additions & 2 deletions static/locales/pt-BR.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -390,8 +390,6 @@ Settings:
o modo paisagem
Skip by Scrolling Over Video Player: Pular vídeo ao rolar sobre o player
Allow DASH AV1 formats: Permitir formatos DASH AV1
Comment Auto Load:
Comment Auto Load: Carregar automaticamente os comentários
Subscription Settings:
Subscription Settings: 'Configurações de inscrições'
Hide Videos on Watch: 'Ocultar vídeos após assisti-los'
Expand Down
2 changes: 0 additions & 2 deletions static/locales/pt-PT.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -383,8 +383,6 @@ Settings:
Enter Fullscreen on Display Rotate: Ativar modo de ecrã completo ao rodar o ecrã
Skip by Scrolling Over Video Player: Ignorar ao deslocar por cima do reprodutor
Allow DASH AV1 formats: Permitir formatos DASH AV1
Comment Auto Load:
Comment Auto Load: Carregamento automático de comentários
Privacy Settings:
Privacy Settings: Configurações de privacidade
Remember History: Memorizar histórico
Expand Down
Loading

0 comments on commit c5f0a8c

Please sign in to comment.