Fix doxygen generation by removing symlink and replacing with folder #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aggarg
approved these changes
May 23, 2024
moninom1
approved these changes
May 23, 2024
|
The changes align with what I expected to see so I'll approve. I would like to know how you tested this. |
kstribrnAmzn
approved these changes
May 23, 2024
|
@kstribrnAmzn, I have tested this change by adding this change in the forked version of the CI-CD repo and did a trial release of the forked coreMQTT (that uses the forked CI-CD repo on my Github): https://github.com/tony-josi-aws/coreMQTT/actions/runs/9206435491/job/25324304903 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Github doesn't allow symlinks in gh-pages anymore while deploying doxygen.
Example: https://github.com/FreeRTOS/coreMQTT/runs/24619176608
Description of changes:
This PR fixes this issue by replacing the symlink and copying the contents to separate folder.
Thanks @kstribrnAmzn for figuring this out.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.