Closing socket correctly. #310
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this ready to be Merged? I am also having the same issue as #296 |
Contributor
|
hope full fixed with latest commit - please check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update:
According to chapter 10.1.3 of part 6 of the specification, the format of the Guid identifier should be:
<Data1>-<Data2>-<Data3>-<Data4[0:1]>-<Data4[2:7]>instead of:
<Data1>-<Data2>-<Data3>-<Data4[0:7]>Added a fix for this issue: #296
It removes the message "Failed to close socket connection. Transport endpoint is not connected" and it allows one to repeatedly use client.Connect() and client.Disconnect() since the sockets gets closed correctly now.