Add mistral backend #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxDavid40
reviewed
Aug 1, 2024
maxDavid40
approved these changes
Aug 1, 2024
mfournioux
approved these changes
Aug 1, 2024
| from benchmark_llm_serving.io_classes import QueryOutput, QueryInput | ||
|
|
||
|
|
||
| class BackEnd(): |
There was a problem hiding this comment.
Why this class is defined in first place?
There was a problem hiding this comment.
In order to force the declaration of some methods in the class which inherits from BackEnd, and to declare common methods as well.
| args.prompt_length = input_length | ||
| args.output_length = output_length | ||
| args.output_file = os.path.join(raw_results_folder, f"kv_cache_profile_input_{input_length}_output_{output_length}.json") | ||
| if backend.backend_name == "happy_vllm": |
There was a problem hiding this comment.
Why this "if" statement is needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the mistral backend.
It also fixes some incompatibilities introduced with the upgrade of vLLM in happy_vLLM