FastAPI backend #109
Merged
FastAPI backend #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This took longer than expected. It's done now. I tested everything thoroughly, and hope nothing broke. Yet with such large changes it's hard to get everything, so please report. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating from flask to FastAPI. There are many reasons why, but tldr: asyncio and decent websocket support. I couldn't get socketio working with non-socketio with Flask (and gevent). Time to ditch flask and use the new tools. Moving the backend to nim is still a possibility, but for another day as it's a larger undertaking. I'll start small with the frame's own webserver.