refactor: bubble init usage and errors to simplify recovery #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoxxMD
force-pushed
the
improveInitUsage
branch
from
ca15854 to
524ba43
Compare
FoxxMD
force-pushed
the
improveInitUsage
branch
from
524ba43 to
0ff1c95
Compare
* try-catch and bubble up depending on usage * replace poll/monitor code on startup with scheduler task usage * better notification messages with truncated cause chain
This was referenced Dec 11, 2024
📦 A new release has been made for this pull request.To play around with this PR, pull an image:
Images are available for x86_64 and ARM64.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Type of change
Please delete options that are not relevant.
Describe your changes
Need to refactor how
initialize()is used so that is bubbles errors instead of just logging them. This way we can use the actual error reasons fornotifyor when user invokes API to show reasons for component not being able to recover. Needs work:initAndLogas convenience methodforceinit when things aren't working as planned and user wants to force a full recoverynotifyusage to pull error causes and consolidate where these happentestAuthto try-catchErrorclasses for init steps to make extracting the desired errorcauseeasier?pollendpoints so allow re-initializing non-polling components as wellIssue number and link, if applicable
#220
#231