Fixes #139 ignore white space character for search with dialpad numbers #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It works, but I'm thinking it would be better to just ignore whitespaces while searching with numbers. Google Phone works this way, so I assume people are used to it. @naveensingh What do you think? |
|
I think using 1 as a substitute for whitespace is quite arbitrary and no one would expect it (even with the "␣").
Agreed. The search itself should be more 'intelligent' and display any relevant results. |
|
Got your point. |
naveensingh
reviewed
Jul 21, 2024
| @@ -368,7 +369,7 @@ class ContactsAdapter( | |||
| if (name.contains(textToHighlight, true)) { | |||
| name.highlightTextPart(textToHighlight, properPrimaryColor) | |||
| } else { | |||
| name.highlightTextFromNumbers(textToHighlight, properPrimaryColor) | |||
| name.highlightTextFromNumbers(textToHighlight.replace('1', ' '), properPrimaryColor) | |||
There was a problem hiding this comment.
I guess this change is no longer needed.
There was a problem hiding this comment.
Yes I just messed up the commits.
Honk2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
When searching contacts using the dialpad, 1 is handled as space character.
Also the white space symbol |_| is displayed below the 1 on the dialpad.
Fixes the following issue(s)
Acknowledgement