fix: make eraser size relative to zoom and consistent with brush #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: make eraser stroke respect zoom and match brush minimum size
naveensingh
requested changes
Apr 20, 2025
Member
|
In addition to #30 (comment):
|
naveensingh
approved these changes
Apr 20, 2025
Member
naveensingh
left a comment
naveensingh
left a comment
There was a problem hiding this comment.
Seems to work fine, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request fixes the issue where the eraser stroke size remained visually large, especially at minimum brush size, and did not scale according to zoom level.
Changes made:
MIN_ERASER_WIDTHcondition that forced a minimum size only for the eraser.Fixes #25 ("Eraser size not relative to zoom on minimum size") as reported.
Let me know if you’d like me to make any adjustments.