Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable installation on Visual Studio 2022 for ARM64 #439

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

craigktreasure
Copy link
Contributor

@craigktreasure craigktreasure commented Jul 20, 2024

This change adds support for the arm64 platform architecture to the VS 2022 extension by updating the Microsoft.VSSDK.BuildTools package to the latest version (17.11.414) and adding a new entry for the arm64 ProductArchitecture.

Built and tested on my Surface Pro 11 running VS 17.10.4 for ARM 64-bit. As best I can tell, everything seems to work.

I believe this PR addresses #436.

It's worth mentioning that the number of warnings produced during the build (at least from my local build) went from 2 to 19. The new warnings are likely due to updated analyzers from the package upgrade. Here are the new warnings:

The new warnings include:

  • 13 of "warning VSTHRD110: Observe the awaitable result of this method call by awaiting it, assigning to a variable, or passing it to another method (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD110.md)"
  • 3 of "warning VSSDK007: Await/join tasks created from ThreadHelper.JoinableTaskFactory.RunAsync (https://github.com/Microsoft/VSSDK-Analyzers/blob/main/doc/VSSDK007.md)"
  • 1 of "warning VSIXCompatibility1001: The extension is incompatible with the targeted version of Visual Studio. More info at https://aka.ms/ExtensionSdkErrors."
    • This one is a bit more concerning as it seems to indicate an issue with other dependencies, but I've not determined how to resolve it. There a similar post on SO, but I'm not seeing similarities with this code base.
        D:\.packages\nuget\microsoft.vssdk.compatibilityanalyzer\17.11.414\build\Microsoft.VsSDK.CompatibilityAnalyzer.targets(36,5): warning VSIXCompati
      bility1001: The extension is incompatible with the targeted version of Visual Studio. More info at https://aka.ms/ExtensionSdkErrors.  [D:\forks\Fi
      neCodeCoverage\FineCodeCoverage2022\FineCodeCoverage2022.csproj]
      D:\.packages\nuget\microsoft.vssdk.compatibilityanalyzer\17.11.414\build\Microsoft.VsSDK.CompatibilityAnalyzer.targets(36,5): warning VSIXCompatibi
      lity1001: Following references are incompatible. [D:\forks\FineCodeCoverage\FineCodeCoverage2022\FineCodeCoverage2022.csproj]
      D:\.packages\nuget\microsoft.vssdk.compatibilityanalyzer\17.11.414\build\Microsoft.VsSDK.CompatibilityAnalyzer.targets(36,5): warning VSIXCompatibi
      lity1001: Microsoft.VisualStudio.TestWindow.Interfaces.dll -> Microsoft.VisualStudio.Shell.Interop [D:\forks\FineCodeCoverage\FineCodeCoverage2022\
      FineCodeCoverage2022.csproj]

@craigktreasure craigktreasure marked this pull request as draft July 20, 2024 15:21
Updated the following packages:
* Microsoft.CodeAnalysis.*: 4.8.0 -> 4.10.0
* Microsoft.VisualStudio.Composition.Analyzers: 17.7.40 -> 17.10.37
* Microsoft.VisualStudio.SDK: 17.1.32210.191 -> 17.10.40171
* Microsoft.VisualStudio.Threading.Analyzers: 17.9.28 -> 17.10.48
* Newtonsoft.Json: 13.0.1 -> 13.0.3
* StreamJsonRpc: 2.16.36 -> 2.18.48
* System.Composition: 7.0.0 -> 8.0.0

These package upgrades were mostly constrained to `FineCodeCoverage.csproj` and `FineCodeCoverageTests.csproj` with the exception of `Newtonsoft.json` which I also updated in `FineCodeCoverage.csproj`.
@craigktreasure craigktreasure marked this pull request as ready for review July 20, 2024 16:37
@tonyhallett
Copy link
Collaborator

So you did not encounter any of the problems from #352 - Excss exception / bad image format exception ?
What version of vs are using to build and run the extension ?

@craigktreasure
Copy link
Contributor Author

I'm using VS 17.10.4 on arm64 to build and run it.

I am not experiencing the issue mentioned there. Not sure how to explain that.

Would be great to get a second opinion.

@craigktreasure
Copy link
Contributor Author

I wonder if @dpmurphy would mind giving my changes a try.

@dpmurphy
Copy link

dpmurphy commented Jul 22, 2024 via email

Copy link

@ScottyLightnin ScottyLightnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I successfully installed and ran this on VS2022 Professional + VS2022 Professional Preview on Surface Laptop 7 Copilot+ running Snapdragon Elite X
image
Thanks so much!

@tonyhallett tonyhallett merged commit f7f01ad into FortuneN:master Jul 22, 2024
3 of 4 checks passed
@tonyhallett
Copy link
Collaborator

@craigktreasure Please use the vsix from the marketplace and let me know if there are any issues. Thanks

@dpmurphy
Copy link

dpmurphy commented Jul 22, 2024 via email

@tonyhallett
Copy link
Collaborator

@dpmurphy
Sorry, I am confused with comment above and #440 (comment)

@dpmurphy
Copy link

dpmurphy commented Jul 22, 2024 via email

@tonyhallett
Copy link
Collaborator

@dpmurphy
Ok at least it works from the marketplace.

The report UI will be changed at some point and Excss will be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants