Add totalPages and currentPage to ref imperative handle#1103
Open
TSMMark wants to merge 1 commit intoFormidableLabs:mainfrom
Open
Add totalPages and currentPage to ref imperative handle#1103TSMMark wants to merge 1 commit intoFormidableLabs:mainfrom
TSMMark wants to merge 1 commit intoFormidableLabs:mainfrom
Conversation
|
@TSMMark is attempting to deploy a commit to the formidable-labs Team on Vercel. A member of the Team first needs to authorize it. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can tidy up this PR if the maintainers would accept this addition. Let me know
Description
Need access to totalPages and currentPage in outer component.
Specifically when multiple slides may be visible per page. The internal totalPages calculation logic needs to be exposed
Fixes # (issue)
Type of Change
How Has This Been Tested?
todo
Checklist
pnpm run lint)pnpm run test:ci-with-server/pnpm run test)pnpm changeset.