Feat : event page #149
Draft
Feat : event page #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JeanneGrenet
commented
Oct 14, 2024
Comment on lines
121
to
120
| startTime: 2024-06-07T08:00:00.000Z | ||
| startDate: 2024-06-07T08:00:00.000Z |
There was a problem hiding this comment.
You change the spelling only for the event on the scheme so It will not work with the schedule. I think we should keep startTime for the schedule because it's the time when the talk start
JeanneGrenet
commented
Oct 14, 2024
src/layouts/SubPagesLayout.astro
Outdated
| @@ -13,7 +13,7 @@ const { title, description } = Astro.props; | |||
| <Layout title={title} description?={description}> | |||
| <slot name="seo" slot="seo" /> | |||
| <div | |||
| class="my-8 space-y-8 prose-h1:mt-6 prose-h1:text-2xl prose-h3:flex prose-h3:items-center prose-h3:gap-2 prose-h3:font-bold prose-h3:text-white" | |||
| class="prose prose-lg prose-invert mx-auto my-8 space-y-8 prose-h1:mt-6 prose-h1:text-2xl prose-h3:flex prose-h3:items-center prose-h3:gap-2 prose-h3:font-bold prose-h3:text-white" | |||
There was a problem hiding this comment.
Good for the prose but I think we should add the tailwind class container to manage the space on mobile
houssembaltii
force-pushed
the
feat/event-page
branch
from
fd1cb1d
to
e1867cd
Compare
houssembaltii
force-pushed
the
feat/event-page
branch
from
e1867cd
to
52c47c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Beginning of the layout for the page of one event
How to test
Create a new event or change the dates inside the
rouen-france-2024 index.mdxfrom 2024 to 2025