Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow returning response headers alongside date via didUpload.withHeaders #1

Conversation

guillaumedeslandes
Copy link

@guillaumedeslandes guillaumedeslandes commented Sep 21, 2020

No description provided.

@guillaumedeslandes guillaumedeslandes force-pushed the feat/transmit-response-headers-to-did-upload-callback branch 3 times, most recently from 15e1588 to 9e77fbd Compare September 21, 2020 14:28
@rap2hpoutre
Copy link

@guillaumedeslandes Could we try to open a PR even if the package is not that maintained? I tried to desperate ping on Github

Copy link

@rap2hpoutre rap2hpoutre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a few comments. Also, I guess we should create a PR on the official repo too.

addon/uploaders/uploader.js Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
tests/unit/uploader-test.js Show resolved Hide resolved
@guillaumedeslandes guillaumedeslandes force-pushed the feat/transmit-response-headers-to-did-upload-callback branch from 8f15b7a to 2686cb8 Compare September 28, 2020 16:14
Copy link

@rap2hpoutre rap2hpoutre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb! 🌞

@guillaumedeslandes guillaumedeslandes merged commit 9785339 into master Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants