Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Blog about working with Time Series Data using FastAI.jl #140

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

codeboy5
Copy link

This blog demonstrates the work done for adding time series support to FastAI.jl as part of GSoC 22. It contains basic sample code and gives an overview of currently supported features under this submodule. Will add more stuff in the future.
This was done under the mentorship of @darsnack @ToucheSir @lorenzoh .

@ToucheSir
Copy link
Member

Do you mind writing up a quick list of additions you have planned? That way we're not suggesting stuff you're already working on :)

@codeboy5
Copy link
Author

codeboy5 commented Sep 12, 2022

Primally I was looking to add these :-

  • More information about the models (diagram, blocks, etc)
  • Examples of the model working (classifying a sample time series)

Would love to hear suggestions on how I could improve this.

Copy link
Member

@darsnack darsnack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments that do not need to be addressed before the GSoC deadline, but they should be taken care of before merging.

The main thing that needs to be done before GSoC is to add some notes about future work, and also include links to the PRs somewhere in the post.

For GSoC, you can preview this page locally and save it as a PDF. Upload that PDF somewhere and create a permalink to it (e.g. Google Drive). This is how Google prefers the submission.

blog/_posts/2022-09-08-FastAI-time-series.md Outdated Show resolved Hide resolved
blog/_posts/2022-09-08-FastAI-time-series.md Outdated Show resolved Hide resolved
blog/_posts/2022-09-08-FastAI-time-series.md Outdated Show resolved Hide resolved
blog/_posts/2022-09-08-FastAI-time-series.md Outdated Show resolved Hide resolved
blog/_posts/2022-09-08-FastAI-time-series.md Outdated Show resolved Hide resolved
The library contains implementation of the following models.
- RNNs
```julia
julia> backbone = FastTimeSeries.Models.StackedLSTM(1, 16, 10, 2);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include a description of what the arguments mean?

blog/_posts/2022-09-08-FastAI-time-series.md Outdated Show resolved Hide resolved

- [InceptionTime](https://www.google.com/search?client=safari&rls=en&q=inceptiontime&ie=UTF-8&oe=UTF-8)
```julia
julia> model = FastTimeSeries.Models.InceptionTime(1, 5);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment about the arguments


## Conclusion

We saw how we can work on time-series data using FastAI.jl.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you expand here more? A summary of everything above as a bulleted list would be good. Think of it as a way for GSoC reviewers to see your contributions at a glance. And as Brian mentioned, add some notes about future work.

@codeboy5
Copy link
Author

codeboy5 commented Sep 12, 2022

I left a few comments that do not need to be addressed before the GSoC deadline, but they should be taken care of before merging.

The main thing that needs to be done before GSoC is to add some notes about future work, and also include links to the PRs somewhere in the post.

For GSoC, you can preview this page locally and save it as a PDF. Upload that PDF somewhere and create a permalink to it (e.g. Google Drive). This is how Google prefers the submission.

Will resolve the comments you guys made.
For GSoC I was planning to submit this gist.
It contains the PRs along with the blogs attached, similar to what manikya did last year.

Copy link
Member

@lorenzoh lorenzoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor style comments

blog/_posts/2022-09-08-FastAI-time-series.md Outdated Show resolved Hide resolved
blog/_posts/2022-09-08-FastAI-time-series.md Outdated Show resolved Hide resolved
blog/_posts/2022-09-08-FastAI-time-series.md Outdated Show resolved Hide resolved
Copy link
Member

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. The biggest addition I think would be providing some visual of what the data and predictions look like, similar to what we've talked about for the notebooks.

@codeboy5
Copy link
Author

Generally LGTM. The biggest addition I think would be providing some visual of what the data and predictions look like, similar to what we've talked about for the notebooks.

Yeah that is in the works, will hopefully add soon.

@mcabbott mcabbott mentioned this pull request Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants