-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Blog about working with Time Series Data using FastAI.jl #140
base: main
Are you sure you want to change the base?
Conversation
Do you mind writing up a quick list of additions you have planned? That way we're not suggesting stuff you're already working on :) |
Primally I was looking to add these :-
Would love to hear suggestions on how I could improve this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments that do not need to be addressed before the GSoC deadline, but they should be taken care of before merging.
The main thing that needs to be done before GSoC is to add some notes about future work, and also include links to the PRs somewhere in the post.
For GSoC, you can preview this page locally and save it as a PDF. Upload that PDF somewhere and create a permalink to it (e.g. Google Drive). This is how Google prefers the submission.
The library contains implementation of the following models. | ||
- RNNs | ||
```julia | ||
julia> backbone = FastTimeSeries.Models.StackedLSTM(1, 16, 10, 2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include a description of what the arguments mean?
|
||
- [InceptionTime](https://www.google.com/search?client=safari&rls=en&q=inceptiontime&ie=UTF-8&oe=UTF-8) | ||
```julia | ||
julia> model = FastTimeSeries.Models.InceptionTime(1, 5); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment about the arguments
|
||
## Conclusion | ||
|
||
We saw how we can work on time-series data using FastAI.jl. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you expand here more? A summary of everything above as a bulleted list would be good. Think of it as a way for GSoC reviewers to see your contributions at a glance. And as Brian mentioned, add some notes about future work.
Will resolve the comments you guys made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor style comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM. The biggest addition I think would be providing some visual of what the data and predictions look like, similar to what we've talked about for the notebooks.
Yeah that is in the works, will hopefully add soon. |
This blog demonstrates the work done for adding time series support to FastAI.jl as part of GSoC 22. It contains basic sample code and gives an overview of currently supported features under this submodule. Will add more stuff in the future.
This was done under the mentorship of @darsnack @ToucheSir @lorenzoh .