Allow pullback through 0-length arrays in unbroadcast
#1530
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm having trouble boiling down a MWE, because it seems to depend on other factors? But it is related to executing the pullback through a form like this:
unbroadcast
only compares lengths of the inputs, but arrays with a 0-length dimension will naturally have the same length. In this PR,NoTangent()
is returned if a zero-length array is recieved.Test for the transform added, but unfortunately without an MWE can't test the broadcast directly.