Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only project sentinels in gradient #1508

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mohamed82008
Copy link
Contributor

This PR fixes #1507. This is technically a bug fix but I bumped the minor version because it is a significant enough change in behaviour. If a patch release is preferred, I can change that. No new documentation is needed because this is a bugfix.

PR Checklist

  • Tests are added
  • Documentation, if applicable

@mohamed82008 mohamed82008 changed the title Only project nothings in gradient Only project sentinels in gradient Mar 24, 2024
@ToucheSir ToucheSir closed this Sep 22, 2024
@ToucheSir ToucheSir reopened this Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradient wrt to a sparse matrix is mathematically wrong
2 participants