Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From my colleague, a perf improvement to Async_file_logger, so it uses somewhat less memory per pending-for-logging message. I then massage that code somewhat. #49

Merged
merged 5 commits into from
Jan 23, 2024

Commits on Jan 23, 2024

  1. From my colleague, the basis of a perf improvement to Async_file_logg…

    …er, so it uses somewhat less memory per pending-for-logging message. I will then massage this code somewhat.
    ygoldfeld committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    59f9765 View commit details
    Browse the repository at this point in the history
  2. My changes are stylistic with one small exception: std::make_unique<c…

    …har[]>(size_t) would zero-initialize the chars, whereas for us that is a waste. Using the technique from Basic_blob (there is also a @todo added to make a util::Tight_blob later, so it can be reused by itself and also Basic_blob would be written in terms of it).
    ygoldfeld committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    3cab428 View commit details
    Browse the repository at this point in the history
  3. Build fix.

    ygoldfeld committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    df4275d View commit details
    Browse the repository at this point in the history
  4. Build fix.

    ygoldfeld committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    07b14c7 View commit details
    Browse the repository at this point in the history
  5. Build fix.

    ygoldfeld committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    9779191 View commit details
    Browse the repository at this point in the history