Skip to content

Commit

Permalink
Workflow renaming, comment tweaks.
Browse files Browse the repository at this point in the history
  • Loading branch information
ygoldfeld committed Jan 19, 2024
1 parent dc8fc8a commit f9152c6
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,17 @@ name: Flow pipeline
# TODO: Code reuse somehow versus Flow-IPC workflow counterpart file? Could apply to major parts of this file.
# The copy/pasting and "see comment in other file" types of comments are a bit unseemly.

# See comment in Flow-IPC workflow counterpart. We follow the same philosophy here.

on:
# Want to merge to development tip? Should probably pass these builds/tests/doc generation first.
pull_request:
branches:
- main
push:
# Was able to merge to development tip? Should ensure these builds/tests/doc generation pass after the fact;
# plus auto-check-in generated docs into development tip branch as well (and signal web site to update accordingly).
branches:
- main
# Created release tag? Just in case, should ensure these builds/tests/doc generation pass after the fact still;
# plus signal web site to update accordingly (new release/docs for it).
tags:
- v*
# To create the button that runs a workflow manually (has to be in `main` at least):
workflow_dispatch:

jobs:
Expand Down Expand Up @@ -52,13 +48,13 @@ jobs:
echo 'proceed-else-not=true' >> $GITHUB_OUTPUT
else
echo 'proceed-else-not=false' >> $GITHUB_OUTPUT
echo 'The real jobs will not run: earlier `doc` job checked-in generated docs to `main`.'
echo 'The real jobs will not run: earlier `doc_and_release` job checked-in generated docs to `main`.'
echo 'That is not a source change and requires no actual pipeline to execute.'
fi
outputs:
proceed-else-not: ${{ steps.compute_proceed_else_not.outputs.proceed-else-not }}

build:
build_and_test:
needs: [setup, set-vars]
if: |
needs.setup.outputs.proceed-else-not == 'true'
Expand Down Expand Up @@ -409,7 +405,7 @@ jobs:
name: flow-test-logs-${{ matrix.compiler.id }}-${{ matrix.build-test-cfg.id }}
path: ${{ env.install-dir }}/bin/logs.tgz

doc:
doc_and_release:
needs: [setup, set-vars]
if: |
needs.setup.outputs.proceed-else-not == 'true'
Expand Down

0 comments on commit f9152c6

Please sign in to comment.