Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added following #13

Merged
merged 1 commit into from
Sep 20, 2019
Merged

added following #13

merged 1 commit into from
Sep 20, 2019

Conversation

VariableVasasMT
Copy link
Contributor

@VariableVasasMT VariableVasasMT commented Apr 29, 2019 •
edited
Loading

  • added qsConfig which accepts qs params supported by qs lib
  • added test for function above

for #9

This change is Reviewable

@VariableVasasMT VariableVasasMT mentioned this pull request Apr 29, 2019
Open
@coveralls
Copy link

coveralls commented Apr 29, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling ea5d65d on VariableVasasMT:feature/issues/9 into d13323d on Floby:master.

@VariableVasasMT
Copy link
Contributor Author

@alexfoxgill please review

@alexfoxgill
Copy link

i am not a contributor, perhaps you meant @Floby

@VariableVasasMT
Copy link
Contributor Author

i am not a contributor, perhaps you meant @Floby

My bad, I saw your name on the #9 , thought you were too, plus it was your feature request

@Floby
Copy link
Owner

Floby commented Apr 30, 2019

Can you please submit your changes without all the reformatting?

@VariableVasasMT
Added:
ea5d65d 
  * config options with option to add qs supported config options
  * added readme changes for above change
  * added test for above change
@VariableVasasMT
Copy link
Contributor Author

@Floby sorry for all the bullshit, please review.

@Floby Floby merged commit 3728dbc into Floby:master Sep 20, 2019
@Floby
Copy link
Owner

Floby commented Sep 20, 2019

@VariableVasasMT Sorry for the delay
published in version 2.1 ! I only change the name of the method to qsConfig

@VariableVasasMT VariableVasasMT deleted the feature/issues/9 branch July 6, 2020 12:51
@VariableVasasMT VariableVasasMT restored the feature/issues/9 branch July 7, 2020 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VariableVasasMT @coveralls @alexfoxgill @Floby