fix: description state management in EnvironmentSettingsPage #4917
+7
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
github-actions
bot
added
front-end
Docker builds report
|
tiagoapolo
requested review from
zachaysan,
matthewelwell,
a team and
kyle-ssg
and removed request for
kyle-ssg and
a team
Uffizzi Ephemeral Environment
|
| @@ -61,7 +61,7 @@ const EnvironmentSettingsPage = class extends Component { | |||
| const env = ProjectStore.getEnvs().find( | |||
| (v) => v.api_key === this.props.match.params.environmentId, | |||
| ) | |||
| this.setState({ env }) | |||
| this.setState({ env, description: env.description ?? "" }) | |||
There was a problem hiding this comment.
I'm interested to know why description has to be handled differently? Shouldn't it just be updated as part of the environment object? 🤔
There was a problem hiding this comment.
My approach here was to make sure we're consistent in how we're getting and updating the data from, previously we were mixing internal states with context one, which in my opinion is more confusing and prone to bugs. So, either using environment object or description internal states is fine.
value={
typeof this.state.description === 'string'
? this.state.description
: env.description
}
zachaysan
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Before
not_fixed.mov
After
fixed.mov
How did you test this code?
Please describe.