Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Numbers such as 1e100 cannot be retrieved from DynamoDB #4916

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Dec 11, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fixes #4915.

How did you test this code?

I'm planning to test in staging by inserting faulty data in the staging identities table.

@khvn26 khvn26 requested a review from a team as a code owner December 11, 2024 18:10
@khvn26 khvn26 requested review from gagantrivedi and removed request for a team December 11, 2024 18:10
Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Dec 11, 2024 6:10pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Dec 11, 2024 6:10pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Dec 11, 2024 6:10pm

@github-actions github-actions bot added api Issue related to the REST API fix labels Dec 11, 2024
Copy link
Contributor

github-actions bot commented Dec 11, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4916 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4916 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4916 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4916 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4916 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4916 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Dec 11, 2024

Uffizzi Preview deployment-59035 was deleted.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.39%. Comparing base (5405cc5) to head (5da54bd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4916   +/-   ##
=======================================
  Coverage   97.39%   97.39%           
=======================================
  Files        1190     1190           
  Lines       41527    41530    +3     
=======================================
+ Hits        40445    40448    +3     
  Misses       1082     1082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khvn26 khvn26 merged commit 5d02ab1 into main Dec 11, 2024
35 checks passed
@khvn26 khvn26 deleted the fix/identities-decimal-rounded-error branch December 11, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rounded: [<class 'decimal.Rounded'>]
2 participants