Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Preserve Page number in URL at AuditLogs page #4913

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix: Preserve Page number in URL at AuditLogs page #4913

merged 1 commit into from
Dec 11, 2024
+23 −2

Conversation

tiagoapolo
Copy link
Contributor

@tiagoapolo tiagoapolo commented Dec 11, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Reference: #4445

  • Use Case 1: loads results and initial page is 1
    • page number is set to 1
    • page number is set in url
    • existing query params are kept in url
  • Use Case 2: user goes to page n > 1
    • page number is set to n
    • page number is set in url
    • existing query params are kept in url
  • Use Case 3: user searches
    • search text is set in url
    • page number is set to 1
    • page number is set in url
    • existing query params are kept in url
  • Use Case 4: results are filtered by search and user goes to page n > 1
    • page number is set to n
    • page number is set in url
    • existing query params are kept in url
fix.mov

How did you test this code?

Please describe.

@vercel Vercel
Copy link

vercel bot commented Dec 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 1:20am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 1:20am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Dec 11, 2024 1:20am

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Dec 11, 2024
@tiagoapolo tiagoapolo self-assigned this Dec 11, 2024
@github-actions github-actions bot added the fix label Dec 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024 •
edited
Loading

Uffizzi Preview deployment-58998 was deleted.

@tiagoapolo tiagoapolo marked this pull request as ready for review December 11, 2024 13:33
@tiagoapolo tiagoapolo requested a review from a team as a code owner December 11, 2024 13:33
@tiagoapolo tiagoapolo requested review from kyle-ssg and a team and removed request for a team December 11, 2024 13:33
@github-actions github-actions bot removed the fix label Dec 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4913 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4913 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4913 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4913 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4913 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4913 Finished ✅ Results ✅

@github-actions github-actions bot added the fix label Dec 11, 2024
matthewelwell
matthewelwell approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via preview - all looks good to me.

@tiagoapolo tiagoapolo merged commit 6cd6cb8 into main Dec 11, 2024
49 checks passed
@tiagoapolo tiagoapolo deleted the fix/audit-log-preserve-page-number branch December 11, 2024 16:41
@flagsmithdev flagsmithdev mentioned this pull request Dec 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

@kyle-ssg kyle-ssg Awaiting requested review from kyle-ssg kyle-ssg is a code owner automatically assigned from Flagsmith/flagsmith-front-end

Assignees

@tiagoapolo tiagoapolo

Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiagoapolo @matthewelwell