Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore make docker-up #4907

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix: Restore make docker-up #4907

merged 2 commits into from
Dec 10, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Dec 10, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Restores the docker-up Make target removed in #4747. Adds conventional file name and a bit of documentation.

How did you test this code?

Ran make docker-up test to verify the local Postgres db is created correctly.

@khvn26 khvn26 requested a review from a team as a code owner December 10, 2024 09:44
@khvn26 khvn26 requested review from gagantrivedi and removed request for a team December 10, 2024 09:44
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 0:56am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 0:56am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 0:56am

@github-actions github-actions bot added api Issue related to the REST API fix labels Dec 10, 2024
Copy link
Contributor

github-actions bot commented Dec 10, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4907 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4907 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4907 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4907 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4907 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Dec 10, 2024

Uffizzi Preview deployment-58976 was deleted.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.38%. Comparing base (05ab7cf) to head (3e20fd7).
Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4907   +/-   ##
=======================================
  Coverage   97.38%   97.38%           
=======================================
  Files        1189     1189           
  Lines       41420    41453   +33     
=======================================
+ Hits        40338    40371   +33     
  Misses       1082     1082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khvn26 khvn26 requested a review from matthewelwell December 10, 2024 10:21
@khvn26 khvn26 merged commit f97c56f into main Dec 10, 2024
15 of 16 checks passed
@khvn26 khvn26 deleted the fix/restore-make-docker-up branch December 10, 2024 12:56
@github-actions github-actions bot added fix and removed fix labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants